zozo123 commented on PR #74466: URL: https://github.com/apache/airflow/pull/74466#issuecomment-6254260463
Thanks! The must-fix is in 4bb265f87e. The pre-sync is now best-effort (`|| echo …`), and its comment says that a stale or missing `uv.lock` only skips the warm-up. I reproduced your matrix against the manifest-only tree from this branch merged with current main, using `--dry-run`: | case | before the change | |---|---| | lock in sync | OK | | new workspace member missing from `uv.lock` | exit 2 | | no `uv.lock` | "Unable to find lockfile" | With the change, both failure cases fall through to the full sync and its existing fallback. On the suggestions: 1. As you said, this is harmless now that the pre-sync fails soft. 2. Agreed that the duplicated `uv sync` flags can drift. I'd keep this PR to the cache layer and follow up with a "locked third-party only" mode in `install_from_sources`, so both layers share one invocation. 3. and 4. I'm leaving these as they are. With 66 of 994 commits touching manifests, keying on the full manifests already hits well. And in upgrade builds the re-executed `RUN` is a no-op. The 13 failing checks came from the Oct 14 base: `mypy-airflow-core` and `test_api_client.py`, which #74731 fixed on main. Main is merged in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
