zhongjiajie commented on a change in pull request #7148: [AIRFLOW-6472] Correct 
short option in cli
URL: https://github.com/apache/airflow/pull/7148#discussion_r367375676
 
 

 ##########
 File path: tests/bin/test_cli.py
 ##########
 @@ -0,0 +1,139 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import re
+from collections import Counter
+from unittest import TestCase
+
+from airflow.bin.cli import CLIFactory
+
+P_LONG_OPTION_ARG = re.compile("^--\\w{2}")
+P_SHORT_OPTION_ARG = re.compile("^-\\w$")
+
+
+class TestCli(TestCase):
 
 Review comment:
   Hi,Jarek should we change long option name style? from `snake_case` to 
`kebab-case`, for example using `airflow tasks test --dry-run` instead of 
`airflow tasks test --dry_run`, I start a [discuss] in dev mail list to discuss 
it 
https://lists.apache.org/thread.html/r95c53953499a236466e0b762dfdadd5ca2ba9d6e2a3516c699a14380%40%3Cdev.airflow.apache.org%3E
  WDYT

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to