dheerajturaga opened a new pull request, #75042:
URL: https://github.com/apache/airflow/pull/75042
### Stack
Stacks on #75041. Stack index: 10 of 20.
A PR from a fork cannot target a fork branch, so each PR in the stack is
based on `main` and contains every commit below it; only the top commit is new.
Review only the commit "AIP-125: Add GET
/api/v2/webhooks/{webhook_name}/deliveries"; the commits below it belong to
earlier PRs in the stack.
### Status
Draft. [AIP-125 (Inbound
Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is
under discussion on dev@ and not yet voted; this stack is its proof of concept
so that voters can run it, and nothing should merge before the vote. The
feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries)
and experimental; no unauthenticated route is reachable until stack PR 18,
which merges last.
### Why
A webhook that stops starting Dags fails silently, so Deployment Managers
need to see what each webhook received and what Airflow did with it. Reading
the list takes GET on the `webhook_<name>` connection, the right that already
guards its secret, and it never returns payloads. A removed webhook keeps its
history readable until `airflow db clean` removes it. The endpoint is
experimental.
### What to look at
- Authorization: `requires_access_webhook` checks the connection
`webhook_<name>`; under FAB that is `Connections.can_read`.
- No payloads: the column is deferred with `raiseload`, and no route returns
a single delivery's payload.
- 404 when the name is outside the grammar, or neither listed nor in the
table; an invalid `[webhooks] names` does not hide history.
- Filters on outcome, delivery id, id, correlation key and `received_at`;
newest first.
- The OpenAPI spec, UI client and airflowctl datamodels are generated.
### Testing
- `test_webhooks.py` and `test_security.py` passed under breeze on SQLite,
Postgres and MySQL; the generator hooks were rerun under breeze at this commit.
### Known limitations
- No airflowctl deliveries command for now.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5.5)
Generated-by: Claude Code (Opus 5.5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
