dheerajturaga opened a new pull request, #75048: URL: https://github.com/apache/airflow/pull/75048
### Stack Stacks on #75047. Stack index: 16 of 20. A PR from a fork cannot target a fork branch, so each PR in the stack is based on `main` and contains every commit below it; only the top commit is new. Review only the commit "AIP-125: Add an inbound webhook source to the GitHub provider"; the commits below it belong to earlier PRs in the stack. ### Status Draft. [AIP-125 (Inbound Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is under discussion on dev@ and not yet voted; this stack is its proof of concept so that voters can run it, and nothing should merge before the vote. The feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) and experimental; no unauthenticated route is reachable until stack PR 18, which merges last. ### Why GitHub deliveries need their `X-Hub-Signature-256` checked and a description core can name, so the `github` source type moves from the proof of concept into the provider that owns GitHub. It keeps the proof of concept's paths and kinds, so subscribed Dags keep their names, answers GitHub's signed `ping` without recording it, and leaves `store_payload` to the deployment, with a summary that drops personal data. ### What to look at - A pull request from a fork picks its own workflow names and head branch, so a `workflow_run` gets its workflow-name detail and `branch` attribute only when it ran on a commit of the repository itself. - Tests check that a branch named outside ASCII, such as `maín`, offers no `push/<branch>` name, so it cannot reach Dags subscribed to pushes to `main`. - `summarize` drops every `email` and the `name` beside it. - No PyGithub import. The `common-compat` floor rises to 1.12.0, the first release whose compat SDK exports `AirflowOptionalProviderFeatureException`, used by the guarded import. ### Testing - `test_github.py` (47 tests) passed under breeze on SQLite, Postgres and MySQL. mypy under breeze reports no issues. After the last fixes, its 53 tests were rerun on SQLite and Postgres, and the final head passed again on MySQL. - The live demo's ping, labeled pull request and redelivery checks passed on Postgres and MySQL. ### Known limitations - Golden fixtures from recorded GitHub deliveries; the tests use synthetic ones. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5.5) Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
