HsuehYi opened a new pull request, #75065: URL: https://github.com/apache/airflow/pull/75065
`breeze ui check-translation-completeness --add-missing` / `--remove-unused` rewrites each locale file with its keys sorted by `natural_sort_key()`, but the order the repo enforces for these files — `jsonc/sort-keys` with `natural: true` (`airflow-core/src/airflow/ui/rules/jsonc.js`) — comes from eslint-plugin-jsonc's `natural-compare`, which is case-sensitive. Any file the command rewrote could therefore be re-ordered back by the `Compile / format / lint UI` (`ts-compile-lint-ui`) pre-commit hook, producing pure churn for contributors (see the 4 key pairs observed while updating the zh-TW locale in #75061). `natural_sort_key()` now reproduces `[email protected]` exactly: digit runs whose first digit is `1`-`9` compare numerically, runs starting with `0` compare character by character, and other characters compare by the same case-sensitive mapping as upstream (digits before `A-Z` before `a-z`, `-` sorting just before digits). The key was checked against the actual `[email protected]` package used by the UI tooling: sorting every `locales/en` key plus edge cases (leading zeros, mixed case, punctuation) produces exactly the same order. `TestNaturalSorting` now covers the four real flipping pairs and the numeric/leading-zero cases. closes: #75063 <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. For user-facing UI changes, please attach before/after screenshots (or a short screen recording) so reviewers can assess the visual impact. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) Generated-by: OpenCode following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
