priyanshujaiz commented on code in PR #74497: URL: https://github.com/apache/airflow/pull/74497#discussion_r4311828634
########## providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/triggers/job.py: ########## Review Comment: Thanks for pointing this out. While reviewing the ordering change, I noticed that the original comment mentions `wait_until_job_complete()` can wait indefinitely while the XCom sidecar is still running, since the sidecar is terminated during XCom extraction. Would moving XCom extraction after the completion loop risk introducing a deadlock when `do_xcom_push=True`? We also need to avoid extracting XCom from stale pods during Kueue preemption and readmission. Would you recommend making the extraction flow suspension-aware while preserving the required sidecar lifecycle, rather than unconditionally moving extraction after Job completion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
