ChickenBenny commented on PR #74869: URL: https://github.com/apache/airflow/pull/74869#issuecomment-6264991089
Thanks both! I've updated the PR: 1. The supervisor now takes `execution_timeout` only from `TIRunContext` (resolved from the serialized Dag), and the Execution API sends it for every task. 2. `SetExecutionTimeout` is replaced with `StartExecutionTimeout`, which no longer carries the seconds and is still sent from the same place. 3. Python tasks start the clock when the supervisor receives `StartExecutionTimeout`; language SDK tasks start it once the runtime has started, before `StartupDetails`. Follow-ups, as discussed: 1. Grace period semantics for language SDK tasks. 2. Decoupling the Python SIGALRM timer. The runner's in-process timer still reads `task.execution_timeout` for now, so I'll move it to `TIRunContext` together with that, instead of in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
