potiuk opened a new pull request, #75119:
URL: https://github.com/apache/airflow/pull/75119

   Since #74461, core `Connection` validates the port when it is set, so 
`test_get_conn_with_wrong_connection_parameters` fails while building 
`Connection(port="as" / "0;" / "-1" / "655536" …)`, before `HiveCliHook`'s own 
beeline-parameter check runs. That breaks the apache.hive tests on main in 
every job that runs them (seen in the Low dep, DB and Non-DB provider jobs).
   
   The hook's check is still needed for older Airflow cores that don't validate 
ports, so the test now passes the invalid values to the hook through a 
`mock.Mock(spec=Connection, ...)` instead of building a real `Connection`.
   
   Tested: `pytest 
providers/apache/hive/tests/unit/apache/hive/hooks/test_hive.py` gives 77 
passed.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5)
   
   Generated-by: Claude Code (Opus 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to