SEPURI-SAI-KRISHNA commented on PR #72449:
URL: https://github.com/apache/airflow/pull/72449#issuecomment-6271927755
Heads up on two small things, neither of them a problem with the change
itself.
The static checks are red on the indentation of the two added lines. They
use tabs where the surrounding call uses spaces, so ruff reports `E101
Indentation contains mixed spaces and tabs` at
`providers/amazon/src/airflow/providers/amazon/aws/sensors/batch.py:105` and
`:106`, and `ruff format` rewrites exactly those two lines and nothing else.
Re-indenting them to line up with `region_name=self.region_name,` above is the
whole fix. `prek run ruff ruff-format --files
providers/amazon/src/airflow/providers/amazon/aws/sensors/batch.py` shows both
locally.
The second thing arrived after this branch was last pushed. The deferred
hook configuration check landed as a prek hook in #73681, and it keeps an
allowlist of sites still waiting for exactly this migration. The allowlist is
checked in both directions, so an entry that is no longer needed fails the
check rather than being ignored. With this PR's two lines applied to current
main, the check reports one error:
```
sensors/batch.py:101 now passes its hook configuration to BatchJobTrigger.
Drop it from PENDING_MIGRATION so the site stays covered.
```
Deleting `("sensors/batch.py", "BatchJobTrigger")` from `PENDING_MIGRATION`
in `scripts/ci/prek/check_deferred_hook_configuration.py` clears it, and the
check then passes with no errors. It has to go in this PR rather than a
follow-up: dropping the entry on its own, before the call site passes the
parameters, fails the check the other way round.
So: rebase onto main, fix the indentation, drop that one allowlist line. The
code change itself is right, `BatchJobTrigger` already takes both parameters
through `**kwargs` and its `hook()` already uses them, and asserting on the
serialized payload is the right thing for the test to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
