uranusjr commented on PR #68359:
URL: https://github.com/apache/airflow/pull/68359#issuecomment-6262103963

   Could you add a test for the expansion recipe before this goes in? 
`iter_dagrun_infos_between(skipped_range.start, skipped_range.end)` is how 
users are told to create intervals, but it doesn't appear in any of the 
skipped-intervals tests. Since the scheduler deliberately doesn't enumerate on 
the hot path, that call is the public contract here.
   
   Ideally assert the expansion yields exactly the skipped set, excluding both 
endpoints' own intervals. Test against both `@daily` and a 
`CronTriggerTimetable`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to