FrankYang0529 opened a new pull request, #75185:
URL: https://github.com/apache/airflow/pull/75185

   Change label form from `airflow.Label(node, text)` to 
`airflow.Label(text).On(node)` as Java SDK's edge labels (#74523).
   
   - `airflow.Label(text)` returns a `*airflow.LabelRef`. `(*LabelRef).On(node, 
more...)` returns the `Node` to pass to `Before` or `After`. The signature of 
`On` requires at least one node, so the compiler rejects a call with none. When 
`On` gets several nodes, the edges to all of them get the same label, as in 
Python's `a >> Label("forks") >> [b, c]`.
   - `airflow.Label` now panics on text that is only white space, not only on 
empty text. `Before` and `After` now panic when their receiver carries a label.
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes - Claude Code
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to