HsuehYi opened a new pull request, #75193:
URL: https://github.com/apache/airflow/pull/75193
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
`mypy --warn-unused-ignores` — exposed to contributors as
`SHOW_UNUSED_MYPY_WARNINGS=true prek run mypy-airflow-ctl --all-files` —
reports three
stale `# type: ignore` comments in `airflow-ctl`:
- `src/airflowctl/api/operations.py:221` — `[union-attr]`
- `src/airflowctl/api/operations.py:224` — `[union-attr]`
- `src/airflowctl/api/operations.py:228` — `[attr-defined]`
`execute_list()` leaves `data_model` untyped, so mypy already infers `Any`
and these
suppressions no longer cover any error.
**Verification (run locally):**
- `prek run mypy-airflow-ctl --all-files` → passed
- the same check with `--warn-unused-ignores` → no findings left in
`airflow-ctl`
- `breeze run --python 3.11 … mypy` (same invocation as the CI static-check
job) → passed
- `ruff format` / `ruff check` → passed
The unused-ignore scan also lists 11 ignores in
`task-sdk/src/airflow/sdk/definitions/decorators/__init__.pyi`, but those
only look unused
when the stub is followed from `airflow-ctl`; the task-sdk hook needs them,
so they are
intentionally left untouched.
No runtime behaviour changes.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — OpenCode (DeepSeek V4.1 Flash Free)
Generated-by: OpenCode (DeepSeek V4.1 Flash Free) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
