This is an automated email from the ASF dual-hosted git repository.
vincbeck pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 12df3270b84 Clean up unused mypy suppressions in standard provider
tests (#75210)
12df3270b84 is described below
commit 12df3270b847f4465560dfdaee945fab27648029
Author: CA <[email protected]>
AuthorDate: Tue Oct 20 20:40:17 2026 +0800
Clean up unused mypy suppressions in standard provider tests (#75210)
The suppressions no longer match any reported error, and a few only need a
narrower ignore code. Keeping them stale makes mypy's unused-ignore checks
noisy and can hide new type errors.
---
.../standard/tests/unit/standard/decorators/test_bash.py | 2 +-
.../standard/tests/unit/standard/decorators/test_python.py | 12 ++++++------
.../tests/unit/standard/decorators/test_short_circuit.py | 2 +-
.../tests/unit/standard/operators/test_latest_only.py | 2 +-
.../tests/unit/standard/sensors/test_external_task.py | 12 ++++++------
.../standard/tests/unit/standard/sensors/test_time_delta.py | 4 ++--
.../standard/tests/unit/standard/sensors/test_weekday.py | 2 +-
7 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/providers/standard/tests/unit/standard/decorators/test_bash.py
b/providers/standard/tests/unit/standard/decorators/test_bash.py
index d3e6c502fb1..19e3f9cae14 100644
--- a/providers/standard/tests/unit/standard/decorators/test_bash.py
+++ b/providers/standard/tests/unit/standard/decorators/test_bash.py
@@ -47,7 +47,7 @@ else:
# bad hack but does the job
from airflow.decorators import task # type: ignore[attr-defined,no-redef]
from airflow.utils.types import ( # type: ignore[attr-defined,no-redef]
- NOTSET as SET_DURING_EXECUTION, # type: ignore[assignment]
+ NOTSET as SET_DURING_EXECUTION,
)
from airflow.providers.common.compat.sdk import timezone
diff --git a/providers/standard/tests/unit/standard/decorators/test_python.py
b/providers/standard/tests/unit/standard/decorators/test_python.py
index bd942a670db..ed0879196cb 100644
--- a/providers/standard/tests/unit/standard/decorators/test_python.py
+++ b/providers/standard/tests/unit/standard/decorators/test_python.py
@@ -54,9 +54,9 @@ else:
)
from airflow.decorators.base import DecoratedMappedOperator,
_TaskDecorator # type: ignore[no-redef]
from airflow.models.baseoperator import BaseOperator # type:
ignore[no-redef]
- from airflow.models.dag import DAG # type: ignore[assignment,no-redef]
+ from airflow.models.dag import DAG # type: ignore[no-redef]
from airflow.models.expandinput import DictOfListsExpandInput # type:
ignore[attr-defined,no-redef]
- from airflow.models.xcom_arg import XComArg # type: ignore[no-redef]
+ from airflow.models.xcom_arg import XComArg
from airflow.utils.task_group import TaskGroup # type: ignore[no-redef]
from airflow.providers.common.compat.sdk import timezone
@@ -64,13 +64,13 @@ from airflow.providers.common.compat.sdk import timezone
if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import TriggerRule
else:
- from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef,attr-defined]
+ from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef]
if AIRFLOW_V_3_2_PLUS:
from airflow.serialization.definitions.mappedoperator import
SerializedMappedOperator
else:
from airflow.models.mappedoperator import ( # type: ignore[no-redef]
- MappedOperator as SerializedMappedOperator, # type:
ignore[assignment,attr-defined]
+ MappedOperator as SerializedMappedOperator,
)
if typing.TYPE_CHECKING:
@@ -931,7 +931,7 @@ def test_upstream_exception_produces_none_xcom(dag_maker,
session):
from airflow.sdk import TriggerRule
except ImportError:
# Compatibility for Airflow < 3.1
- from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef,attr-defined]
+ from airflow.utils.trigger_rule import TriggerRule
result = None
@@ -973,7 +973,7 @@ def
test_multiple_outputs_produces_none_xcom_when_task_is_skipped(dag_maker, ses
from airflow.sdk import TriggerRule
except ImportError:
# Compatibility for Airflow < 3.1
- from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef,attr-defined]
+ from airflow.utils.trigger_rule import TriggerRule
result = None
diff --git
a/providers/standard/tests/unit/standard/decorators/test_short_circuit.py
b/providers/standard/tests/unit/standard/decorators/test_short_circuit.py
index 357d25e25f1..06954d0999d 100644
--- a/providers/standard/tests/unit/standard/decorators/test_short_circuit.py
+++ b/providers/standard/tests/unit/standard/decorators/test_short_circuit.py
@@ -24,7 +24,7 @@ try:
from airflow.sdk import TriggerRule
except ImportError:
# Compatibility for Airflow < 3.1
- from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef,attr-defined]
+ from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef]
from airflow.utils.state import State
from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_1,
AIRFLOW_V_3_0_PLUS
diff --git
a/providers/standard/tests/unit/standard/operators/test_latest_only.py
b/providers/standard/tests/unit/standard/operators/test_latest_only.py
index 62cc653dfd5..ed414ebe328 100644
--- a/providers/standard/tests/unit/standard/operators/test_latest_only.py
+++ b/providers/standard/tests/unit/standard/operators/test_latest_only.py
@@ -33,7 +33,7 @@ try:
from airflow.sdk import TriggerRule
except ImportError:
# Compatibility for Airflow < 3.1
- from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef,attr-defined]
+ from airflow.utils.trigger_rule import TriggerRule # type:
ignore[no-redef]
from airflow.providers.common.compat.sdk import timezone
from airflow.timetables.base import DataInterval
from airflow.utils.state import State
diff --git
a/providers/standard/tests/unit/standard/sensors/test_external_task.py
b/providers/standard/tests/unit/standard/sensors/test_external_task.py
index d87f47ea691..45c6c8329e2 100644
--- a/providers/standard/tests/unit/standard/sensors/test_external_task.py
+++ b/providers/standard/tests/unit/standard/sensors/test_external_task.py
@@ -81,7 +81,7 @@ def _make_dagbag(dag_folder):
"""
if AIRFLOW_V_3_3_PLUS:
return DagBag(dag_folder=dag_folder)
- return DagBag(dag_folder=dag_folder, include_examples=False) # type:
ignore[call-arg]
+ return DagBag(dag_folder=dag_folder, include_examples=False)
if AIRFLOW_V_3_0_PLUS:
@@ -90,7 +90,7 @@ if AIRFLOW_V_3_0_PLUS:
from airflow.utils.types import DagRunTriggeredByType
else:
from airflow.decorators import task as task_deco # type:
ignore[attr-defined,no-redef]
- from airflow.models import BaseOperator # type:
ignore[assignment,no-redef]
+ from airflow.models import BaseOperator
if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import TaskGroup
@@ -100,7 +100,7 @@ else:
if AIRFLOW_V_3_2_PLUS:
from airflow.dag_processing.dagbag import DagBag
else:
- from airflow.models.dagbag import DagBag # type: ignore[attr-defined,
no-redef]
+ from airflow.models.dagbag import DagBag # type: ignore[no-redef]
pytestmark = pytest.mark.db_test
@@ -2019,8 +2019,8 @@ def run_tasks(
session=session,
)
else:
- runs[dag.dag_id] = dagrun = dag.create_dagrun( # type:
ignore[attr-defined,call-arg,union-attr]
- run_id=dag.timetable.generate_run_id( # type:
ignore[attr-defined,call-arg,union-attr]
+ runs[dag.dag_id] = dagrun = dag.create_dagrun( # type:
ignore[call-arg,union-attr]
+ run_id=dag.timetable.generate_run_id( # type:
ignore[call-arg,union-attr]
run_type=DagRunType.MANUAL,
logical_date=logical_date,
data_interval=data_interval,
@@ -2238,7 +2238,7 @@ def dag_bag_cyclic():
sync_dag_to_db(dag)
dag_bag.bag_dag(dag=dag)
else:
- dag_bag.bag_dag(dag=dag, root_dag=dag) # type:
ignore[call-arg]
+ dag_bag.bag_dag(dag=dag, root_dag=dag)
return dag_bag
diff --git a/providers/standard/tests/unit/standard/sensors/test_time_delta.py
b/providers/standard/tests/unit/standard/sensors/test_time_delta.py
index b0c201583b3..814ffe81910 100644
--- a/providers/standard/tests/unit/standard/sensors/test_time_delta.py
+++ b/providers/standard/tests/unit/standard/sensors/test_time_delta.py
@@ -47,7 +47,7 @@ from tests_common.test_utils.version_compat import (
if AIRFLOW_V_3_2_PLUS:
from airflow.dag_processing.dagbag import DagBag
else:
- from airflow.models.dagbag import DagBag # type: ignore[attr-defined,
no-redef]
+ from airflow.models.dagbag import DagBag # type: ignore[no-redef]
pytestmark = pytest.mark.db_test
@@ -72,7 +72,7 @@ class TestTimedeltaSensor:
if AIRFLOW_V_3_3_PLUS:
self.dagbag = DagBag(dag_folder=DEV_NULL)
else:
- self.dagbag = DagBag(dag_folder=DEV_NULL, include_examples=False)
# type: ignore[call-arg]
+ self.dagbag = DagBag(dag_folder=DEV_NULL, include_examples=False)
self.dag = DAG(TEST_DAG_ID, schedule=timedelta(days=1),
start_date=DEFAULT_DATE)
def test_timedelta_sensor(self, mocker):
diff --git a/providers/standard/tests/unit/standard/sensors/test_weekday.py
b/providers/standard/tests/unit/standard/sensors/test_weekday.py
index 69f2d82bf7b..b031d22268a 100644
--- a/providers/standard/tests/unit/standard/sensors/test_weekday.py
+++ b/providers/standard/tests/unit/standard/sensors/test_weekday.py
@@ -37,7 +37,7 @@ from tests_common.test_utils.version_compat import (
if AIRFLOW_V_3_2_PLUS:
from airflow.dag_processing.dagbag import DagBag
else:
- from airflow.models import DagBag # type: ignore[attr-defined, no-redef]
+ from airflow.models import DagBag
pytestmark = pytest.mark.db_test
