pierrejeambrun commented on code in PR #70783:
URL: https://github.com/apache/airflow/pull/70783#discussion_r4338768150
##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -185,6 +188,17 @@ def get_fastapi_middlewares(self) ->
list[tuple[_MiddlewareFactory[Any], dict[st
"""
return []
+ def get_jwt_refresh_middleware(self) ->
list[tuple[_MiddlewareFactory[Any], dict[str, Any]]]:
Review Comment:
Since this is now the extension point for auth managers, could the docstring
say what overriding it is for? For example: return a `JWTRefreshMiddleware`
subclass to change how the user is resolved, return `[]` to disable cookie
refresh, or pass different kwargs. Also note that cores before this release
ignore it, so providers need a version check. The "Refreshing JWT Token"
section in `core-concepts/auth-manager/index.rst` would be a good place to
mention it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
