dheerajturaga opened a new pull request, #75338:
URL: https://github.com/apache/airflow/pull/75338

   Part of [AIP-125 (Inbound 
Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7), 
which lets external services such as GitHub trigger Dags by sending webhooks to 
Airflow.
   
   This is part of Phase 2 (webhook waits and asset routes), which targets 
Airflow 3.5. As a standard provider change, it ships in a standard provider 
release after Airflow 3.5.0 rather than with Airflow.
   
   Webhook waits match deliveries on their attributes, and keep a delivery that 
arrives before its wait only when it has a correlation key. The `hmac_json` and 
`token_header` source types set only `event` and `path`, so a service without a 
source type of its own could not be waited on. Two optional connection-extra 
keys close that gap: `attribute_paths` maps attribute names to dotted paths in 
the body, and `correlation_key_field` names the field that says what a delivery 
is about, such as a job run id.
   
   - Only a non-empty string or an integer becomes an attribute or a key, since 
waits compare values as strings; any other value is left out rather than the 
delivery refused. An attribute's integer must also be in the signed 64-bit 
range, because MySQL keeps a larger one in a JSON column as a double. A 
correlation key is stored as text, so it takes any integer, but one longer than 
255 characters is dropped.
   - Core has no rule for attribute names yet, so the sources take a strict one 
that can be relaxed later: at most 64 lowercase letters, digits and 
underscores, starting with a letter, and not `event` or `path`, which the 
sources set themselves. An invalid `attribute_paths` leaves the webhook 
misconfigured. It may also be given as JSON text, for connections given as a 
URI.
   - The `inbound_webhook` connection form gains `asset_routes`, which core 
reads (#75337) and the sources don't. Its description and the connection docs 
say what core accepts, so they have to stay in step with #75337.
   - The `store_payload` description now says that attributes, the correlation 
key and the partition keys that asset routes read are kept whatever it is set 
to, and warns against mapping personal data into them.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to