kaxil commented on code in PR #72940:
URL: https://github.com/apache/airflow/pull/72940#discussion_r4340290065
##########
registry/src/provider-version.njk:
##########
@@ -334,6 +317,33 @@ eleventyComputed:
</section>
{% endif %}
+ {% if externalServiceRows.length > 0 %}
+ <section class="external-services-card card">
+ <h3>
+ <svg fill="none" stroke="currentColor" viewBox="0 0 24 24"
aria-hidden="true">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2"
d="M11 5.882V19.24a1.76 1.76 0 01-3.417.592l-2.147-6.15M18 13a3 3 0 100-6M5.436
13.683A4.001 4.001 0 017 6h1.832c4.1 0 7.625-1.234
9.168-3v14c-1.543-1.766-5.067-3-9.168-3H7a3.988 3.988 0 01-1.564-.317z" />
+ </svg>
+ External Services ({{ externalServiceRows.length }})
Review Comment:
This counts connection types that declare services, not services. On
common.ai it renders as "External Services (7)" right under "Connections (7)",
while the table lists 30-odd distinct services (over 30 under `pydanticai`
alone), so the number reads as wrong. I'd drop the count, or count distinct
services with the `externalServices` filter, which already does the
case-insensitive dedupe for the /providers/ filter box.
##########
registry/src/provider-version.njk:
##########
@@ -334,6 +317,33 @@ eleventyComputed:
</section>
{% endif %}
+ {% if externalServiceRows.length > 0 %}
Review Comment:
On Snowflake this card lands below URI Schemes (it declares `asset-uris`),
so the `pydanticai_snowflake` row ends up a card away from the Connections card
it describes. Could this block move up to right after the Connections
`</section>`?
##########
registry/src/css/main.css:
##########
@@ -4020,20 +4027,20 @@ main {
background: var(--bg-tertiary);
}
-.provider-detail-page .connections-card .conn-external-services-row {
+.provider-detail-page .external-services-card .external-services-row {
border-top: 1px solid var(--border-primary);
}
-.provider-detail-page .connections-card .conn-external-services-row td {
+.provider-detail-page .external-services-card .external-services-row td {
padding: var(--space-2) var(--space-3);
vertical-align: top;
}
-.provider-detail-page .connections-card .conn-external-services-row
td:first-child {
+.provider-detail-page .external-services-card .external-services-name {
Review Comment:
Nothing styles the `code` in this column, so connection ids render in the
browser's default monospace at 16px, bigger than the 14px service list beside
them. The sibling cards size theirs (`.technical code`, `.uri-schemes dd
code`); `font-family: var(--font-mono); font-size: var(--text-sm)` on
`.external-services-name code` would match.
##########
registry/src/css/main.css:
##########
@@ -4004,14 +4011,14 @@ main {
border-color: var(--color-green-400);
}
-/* Per-connection external services matrix */
-.provider-detail-page .connections-card .conn-external-services-table {
+/* Merged external services table (Connection rows + Toolset rows). */
Review Comment:
Stale after dropping toolsets: there are no toolset rows. The comment at
L3948-3952 also narrates the move ("now lives only under..."); "Connections and
External Services cards share padding and heading style" would cover it.
##########
registry/src/provider-version.njk:
##########
@@ -334,6 +317,33 @@ eleventyComputed:
</section>
{% endif %}
+ {% if externalServiceRows.length > 0 %}
+ <section class="external-services-card card">
+ <h3>
+ <svg fill="none" stroke="currentColor" viewBox="0 0 24 24"
aria-hidden="true">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2"
d="M11 5.882V19.24a1.76 1.76 0 01-3.417.592l-2.147-6.15M18 13a3 3 0 100-6M5.436
13.683A4.001 4.001 0 017 6h1.832c4.1 0 7.625-1.234
9.168-3v14c-1.543-1.766-5.067-3-9.168-3H7a3.988 3.988 0 01-1.564-.317z" />
+ </svg>
+ External Services ({{ externalServiceRows.length }})
+ </h3>
+ <table class="external-services-table">
+ <thead>
+ <tr class="external-services-header">
+ <th>Name</th>
Review Comment:
Every row is a connection type again now that toolsets are gone, and outside
the Connections card "Name" doesn't tell a visitor what `pydanticai_bedrock`
is. Can we go back to "Connection type"? The docs directive uses that header
too. A one-line intro like the URI Schemes card's `<p>` would also say where
the list comes from and that it's examples, not a full list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
