o-nikolas commented on code in PR #75255:
URL: https://github.com/apache/airflow/pull/75255#discussion_r4343327818
##########
airflow-core/src/airflow/utils/log/file_task_handler.py:
##########
@@ -412,6 +414,18 @@ def _get_compatible_log_stream(
)
+def _get_team_executor_name(executor: str | None, team_name: str) ->
ExecutorName:
Review Comment:
Yeah, big plus one here, otherwise these implementations are going to drift.
Also, reviewing this code and looking at the other lookup logic in the
scheduler, made me realize that is actually returning a global executor in some
cases when it should be a team based executor, PR to fix that:
https://github.com/apache/airflow/pull/75362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
