FrankYang0529 commented on code in PR #75190:
URL: https://github.com/apache/airflow/pull/75190#discussion_r4344183479
##########
ts-sdk/src/sdk/dag.ts:
##########
@@ -1189,7 +1252,22 @@ export class Dag {
}
#addOrderEdge(upstreamNode: Node, downstreamNode: Node, verb: "before" |
"after"): void {
- const text = labelledNodes.get(verb === "before" ? downstreamNode :
upstreamNode)?.text;
+ // Calling before() or after() on a labelled node throws, so only the
argument can be a
+ // labelled node.
+ const argument = verb === "before" ? downstreamNode : upstreamNode;
+ const labelled = labelledNodes.get(argument);
+ for (const node of labelled?.nodes ?? [argument]) {
Review Comment:
`#addOrderEdge` now checks every edge of a labelled argument before it
records the first one. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
