himanshuchawla0807-gif opened a new pull request, #75384:
URL: https://github.com/apache/airflow/pull/75384

   The Variables upload form currently accepts any valid JSON value as a 
dictionary. For example, `["example"]` enables Import and is converted by 
`Object.entries` into a variable named `0`; a JSON string is split into 
character-indexed variables. Numbers and booleans also enable an empty import, 
while `null` silently leaves the button disabled.
   
   Require a non-null, non-array JSON object before enabling Import. Other 
document shapes now use the existing translated error, which already explains 
the expected key/value format. Nested values inside a valid object are 
preserved.
   
   Validation:
   - Five invalid-document regression cases fail on unchanged main; all six 
component tests pass with the fix, including a valid-object submission control.
   - Full UI suite: 2,038 tests across 250 files pass. Simple-auth UI: 1 test 
passes.
   - TypeScript, scoped ESLint, production UI build, regular/manual prek checks 
and commit hooks pass. `breeze verify --json` selects both UI suites, which 
were run. Manual hooks unrelated to these files correctly skip.
   - Actual component browser fixture confirms the same array enables Import 
before the change and shows the error with Import disabled afterward. This is 
local component verification, not a deployed Airflow/API end-to-end test.
   
   | Before | After |
   | --- | --- |
   | ![Array wrongly enables 
Import](https://raw.githubusercontent.com/himanshuchawla0807-gif/airflow/4ec80bc890c7509098e040fcd49d9c0862ad529a/variables-before.png)
 | ![Array shows an error and Import stays 
disabled](https://raw.githubusercontent.com/himanshuchawla0807-gif/airflow/4ec80bc890c7509098e040fcd49d9c0862ad529a/variables-after.png)
 |
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — OpenAI Codex
   
   Generated-by: OpenAI Codex following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   No prior human review is claimed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to