uranusjr commented on code in PR #71757:
URL: https://github.com/apache/airflow/pull/71757#discussion_r4346982642
##########
scripts/tests/ci/prek/test_lang_sdk_compat_matrix.py:
##########
@@ -32,19 +32,38 @@ def _doc(sdk_id: str = "go", **overrides) -> dict:
"supervisor_schema_version": "2026-06-16",
"min_airflow_version": "3.3",
"states": {state: _entry(True, since="3.3") for state, _ in
matrix.STATE_DIMENSIONS},
- "capabilities": {cap.name: _entry(True, since="3.3") for cap in
matrix.CAPABILITY_DIMENSIONS},
+ "capabilities": {
+ cap.name: {mode: _entry(True, since="3.3") for mode in
matrix.AUTHORING_MODES}
+ if cap.name in matrix.SHARED_CAPABILITY_NAMES
+ else _entry(True, since="3.3")
+ for cap in matrix.CAPABILITY_DIMENSIONS
+ },
}
doc.update(overrides)
return doc
-class TestValidateCapabilities:
+def _doc_without_dag_definition(sdk_id: str = "go") -> dict:
+ """A valid document for an SDK that does not define Dags in its own
language."""
+ doc = _doc(sdk_id)
+ doc["capabilities"][matrix.DAG_DEFINITION_GATE] = _entry(False)
+ for row in matrix.build_matrix_parts()[1].groups[0].rows:
Review Comment:
I don’t like this uses a magical `[1]` (and elsewhere there are `[1:]`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
