kaxil commented on PR #73433: URL: https://github.com/apache/airflow/pull/73433#issuecomment-6347708820
- The PR description still describes the newest-parse approach (`>=`, `processed_recently` sharing the helper, one test per lookup site). Could you update it to match the diff? - The timed-out tests ([L1246](https://github.com/apache/airflow/blob/27e82d53107e7312f29f5516c71293b3eeaa05a8/airflow-core/tests/unit/dag_processing/test_manager.py#L1246), [L1269](https://github.com/apache/airflow/blob/27e82d53107e7312f29f5516c71293b3eeaa05a8/airflow-core/tests/unit/dag_processing/test_manager.py#L1269)) and the callback-only test ([L1223](https://github.com/apache/airflow/blob/27e82d53107e7312f29f5516c71293b3eeaa05a8/airflow-core/tests/unit/dag_processing/test_manager.py#L1223)) pass whether or not the setup wrote the versioned entry, because the helper ignores it once a scan entry exists. Asserting it before `prepare_file_queue` (`mock_kill` called with `SIGKILL` and `last_finish_time` set, or `None` in the callback-only case) keeps them meaningful if the setup drifts. - @fahadabdul's gauge report checks out: `prepare_file_queue` passes every `_file_stats` value to `emit_metrics` ([L1648](https://github.com/apache/airflow/blob/27e82d53107e7312f29f5516c71293b3eeaa05a8/airflow-core/src/airflow/dag_processing/manager.py#L1648)), so a timed-out versioned callback keeps `dag_processing.import_errors` at 1 while the UI shows 0. Passing `self._resolve_stats_by_presence_key().values()` there fixes it with the helper this PR adds, so it seems worth folding in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
