kaxil commented on code in PR #75425:
URL: https://github.com/apache/airflow/pull/75425#discussion_r4353436721
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -488,7 +488,11 @@ def _get_conn_params(self) -> dict[str, str | None]:
This is used in ``get_uri()`` and ``get_conn()``.
"""
static_config = self._get_static_conn_params
- conn_config = dict(static_config)
+ conn_config: dict[str, Any] = dict(static_config)
+ # The connector merges the server's session parameters, AUTOCOMMIT
among them, into the dict it is
Review Comment:
This is true for connector 3.x and 4.x, but 5.0 keeps session parameters in
a `SessionParametersProxy` and no longer writes the server's values into the
dict it's given, so the copy is a no-op there. Could the comment say
`snowflake-connector-python < 5`? Then whoever raises the floor past 5 knows
the copy can go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
