Jonghyun-An commented on PR #74145: URL: https://github.com/apache/airflow/pull/74145#issuecomment-6357105096
> Thanks for the updates. The retry handling and the cleanup after a disconnect look good to me as is. > > Two more things might be worth trying, if you have time. > > * Rerunning the tests on Python 3.11, since main now requires 3.11 or later. > * Trying the sensor in a real Dag against an FTP server. Thanks for the review. I reran the FTP tests on Python 3.11.16 in Breeze, and all 79 passed. I also ran the sensor in local Dags against a pyftpdlib FTP server. With fail_on_transient_errors=False, it reconnected after a 421 reply and succeeded on the next poke. The default policy and an unknown 430 reply failed as expected. The CI runs are still waiting for maintainer approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
