seanghaeli opened a new pull request, #75449:
URL: https://github.com/apache/airflow/pull/75449

   Depends on #75251; the first commit here is #75251 unchanged, so once that 
merges this can merge as is.
   
   Follow-up to #74399. AwsEksExecutor installed its client through 
`[kubernetes_executor] client_factory`, so a KubernetesExecutor in the same 
scope would have sent its pods to the EKS cluster, and the factory couldn't 
tell teams apart, so #74399 shipped two guards that refuse both setups. With 
#75251 the executor sets its factories on the class and reads 
`[aws_eks_executor]` (cluster, region, connection) and 
`check_health_on_startup` per team, so both guards are gone, and `airflow 
kubernetes cleanup-pods --team` connects to an EKS team's own cluster too. The 
`cncf.kubernetes` extra is marked `# use next version` so it picks up the cncf 
release with #75251. I tested it on two real EKS clusters:
   
   ```
   before (main 31994976b5):
   two teams:     ValueError: AwsEksExecutor doesn't support team-specific 
[aws_eks_executor] config yet, but team team_a sets cluster_name, region_name. 
...
   side by side:  ValueError: AwsEksExecutor can't run alongside 
KubernetesExecutor in the global scope. ...
   
   after:
   two teams:     cluster A: tc-team-a-where-am-i-1x3irj92  Succeeded   cluster 
B: tc-team-b-where-am-i-4kivbcn7  Succeeded
   side by side:  cluster A: tc-side-by-side-on-awseksexecutor-0dib14z9  
Succeeded   cluster B: tc-side-by-side-on-kubernetesexecutor-nklycx74  Succeeded
   airflow kubernetes cleanup-pods --team team_b --allow-shared-namespace:
                  TOKEN cluster=eks-team-b-lane proc='airflow kubernetes 
cleanup-pods'
                  cluster A: tc-team-a-where-am-i-bwsgx61x  Succeeded (kept)   
cluster B: (none)
   ```
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to