ashb commented on PR #74752: URL: https://github.com/apache/airflow/pull/74752#issuecomment-6362108166
**Scope (non-blocking).** The title and description are about loops, but the diff also adds generic facet fields (`state`, `max_tries`, bundle name/version for stored task instances, the `rendered_map_index` rework, `retry_delay`, job-facet `trigger_rule`/`depends_on_past`/`retries`) and three non-loop system-test Dags (retry, sensor reschedule, task states), ~11k lines in total. Splitting into (1) loop/region/runId, (2) generic facet fields, (3) system-test expansion would let each be reviewed on its own. The problems in the inline comments sit in (1) (scheduler placement) and (3) (Airflow 3.0 expectations). Minor: - `sort_by_execution` is defined identically in `example_openlineage_task_loop_dag.py` and `example_openlineage_task_loop_groups_dag.py`; the "every task event's identity: ..." paragraph is pasted into five Dag docstrings. - `test_stored_task_instance_in_loop_has_loop_index_and_max_iterations` (test_utils.py:4804) never asserts `max_iterations`. - A scheduler-sent FAIL for a mapped task without `map_index_template` no longer carries `taskInstance.rendered_map_index` (`"2"` before, absent now). That is parity with the worker, but it is consumer-visible and could use a changelog note. - `openlineage_manual_lineage_dag.json`: the added START/COMPLETE entries only assert `try_number`; they exist so the integrity check sees the lifecycle, which is fine, but they add no field coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
