uranusjr commented on code in PR #75445:
URL: https://github.com/apache/airflow/pull/75445#discussion_r4358255222
##########
airflow-core/docs/authoring-and-scheduling/language-sdks/typescript.rst:
##########
@@ -595,23 +595,25 @@ for the full concept, including the equivalent Python API.
let jobId = await store.get<string>("job_id");
if (jobId == null) {
jobId = await submitSparkJob();
- await store.set("job_id", jobId, { retentionMs: NEVER_EXPIRE });
+ await store.set("job_id", jobId, { retentionSeconds: NEVER_EXPIRE });
}
const result = await waitForSparkJob(jobId);
await store.delete("job_id");
return result;
}
-**Retention.** ``retentionMs`` is milliseconds to retain the key, counted from
the time of the write:
+**Retention.** ``retentionSeconds`` is seconds to retain the key, counted from
the time of the write.
+Every duration in this SDK is a number of seconds, ``executionTimeout`` and
``retryDelay`` included:
Review Comment:
This is useful, but it reads more like a note about the change than a
general rule. Consider putting it once in a general "Types/durations" section
and linking to it, instead of placing it under the state-store retention
section.
This also strengthens the point for `retentionSeconds` being misnamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
