kaxil commented on code in PR #75417:
URL: https://github.com/apache/airflow/pull/75417#discussion_r4359652496
##########
airflow-core/tests/unit/models/test_mappedoperator.py:
##########
@@ -1956,15 +1956,18 @@ def group(value):
assert states[task_id] == {0: "success", 1: "skipped"}
-def
test_none_failed_min_one_success_trigger_rule_expands_in_mapped_task_group(dag_maker):
- """Regression test for #39801.
[email protected](
+ "trigger_rule", [TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS,
TriggerRule.ALL_DONE_MIN_ONE_SUCCESS]
+)
+def test_min_one_success_trigger_rule_expands_in_mapped_task_group(dag_maker,
trigger_rule):
+ """Regression test for #39801 and its ``ALL_DONE_MIN_ONE_SUCCESS``
counterpart.
Review Comment:
Since this line is being rewritten anyway, could the docstring describe the
behaviour rather than point at #39801? The test name and docstring can say
what's tested, and the PR already links the issue. Something like ``A
``*_MIN_ONE_SUCCESS`` task in a mapped task group expands and runs once its
in-group upstream succeeds.``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
