larryzhu2018 commented on a change in pull request #7141: [AIRFLOW-6544] add 
log_id to end-of-file mark and also add an index config for logs
URL: https://github.com/apache/airflow/pull/7141#discussion_r368107102
 
 

 ##########
 File path: tests/utils/log/test_es_task_handler.py
 ##########
 @@ -81,6 +85,17 @@ def setUp(self):
         self.ti.try_number = 1
         self.ti.state = State.RUNNING
         self.addCleanup(self.dag.clear)
+        self.index_name2 = "test_index2"
+        self.es_task_handler2 = ElasticsearchTaskHandler(
+            self.local_log_location,
 
 Review comment:
   can you please suggest anything more meaningful. I would be happy to 
accommodate. it is literally handler2 with test_index2. Because the index name 
is part of the handler, we need to use a separate log handler here in order to 
use a different index name here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to