[
https://issues.apache.org/jira/browse/AIRFLOW-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018358#comment-17018358
]
ASF GitHub Bot commented on AIRFLOW-6586:
-----------------------------------------
jaketf commented on pull request #7197: [AIRFLOW-6586] Improvements to gcs
sensor
URL: https://github.com/apache/airflow/pull/7197
refactors GoogleCloudStorageUploadSessionCompleteSensor to use set instead
of number of objects
add poke mode only decorator
assert that poke_mode_only applied to child of BaseSensorOperator
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GCSUploadSessionCompleteSensor breaks in reschedule mode.
> ---------------------------------------------------------
>
> Key: AIRFLOW-6586
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6586
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.3
> Reporter: Jacob Ferriero
> Priority: Minor
>
> This sensor is stateful and loses state between reschedules.
> We should:
> # Warn about this in docstring
> # Add a `poke_mode_only` class decorator for sensors that aren't safe in
> reschedule mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
