ChickenBenny opened a new issue, #75547: URL: https://github.com/apache/airflow/issues/75547
### Under which category would you file this issue? Airflow Core ### Apache Airflow version main ### What happened and how to reproduce it? Serialization omits a task field when it matches `client_defaults` or the schema default, but `timedelta` fields never match: the operator value (`timedelta(seconds=300)`) is compared with the serialized one (`300.0`). So every task carries these fields itself: | Config | `client_defaults.tasks` | Each task's `__var` | |---|---|---| | Defaults | none | `retry_delay: 300.0` | | `default_task_execution_timeout=60`, `default_task_retry_delay=120` | `execution_timeout: 60.0`, `retry_delay: 120.0` | `retry_delay: 120.0`, `execution_timeout: 60.0` | The comparisons are in `SerializedBaseOperator._matches_client_defaults` and the schema-default check in `_is_excluded` (`airflow-core/src/airflow/serialization/serialized_objects.py`). `generate_client_defaults` already compares the serialized value for this case. Behavior is unaffected, since deserialization merges `client_defaults` back. Only the serialized Dag is larger than needed. ### What you think should happen instead? _No response_ ### Operating System _No response_ ### Deployment None ### Apache Airflow Provider(s) _No response_ ### Versions of Apache Airflow Providers _No response_ ### Official Helm Chart version Not Applicable ### Kubernetes Version _No response_ ### Helm Chart configuration _No response_ ### Docker Image customizations _No response_ ### Anything else? Behavior is unaffected, since deserialization merges `client_defaults` back. Only the serialized Dag is larger than needed. Trade-off of fixing it: `retry_delay` is in every task even with default config, so a fix changes the `dag_hash` of almost every Dag, and each one gets a new Dag version once after upgrading. Is this worth fixing in a minor release, given that? If so, I'd like to work on it. ### Are you willing to submit PR? - [x] Yes I am willing to submit a PR! ### Code of Conduct - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
