fat-catTW commented on code in PR #74446:
URL: https://github.com/apache/airflow/pull/74446#discussion_r4367052243


##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########


Review Comment:
   Thanks for the update!
   
   I noticed callbacks with invalid Dag run context are currently only logged 
and remain `PENDING`, so the Scheduler selects and skips them repeatedly. Could 
you mark these callbacks as `FAILED` too, and add coverage for both a missing 
`dag_run_id` and a missing Dag run?
   Please also update the PR description to say that callbacks which cannot be 
submitted because their required Dag run context is missing or invalid are 
marked `FAILED` as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to