ChickenBenny commented on PR #75551: URL: https://github.com/apache/airflow/pull/75551#issuecomment-6407272895
Added both. vet makes sure it still compiles on 32-bit, and go test actually runs the tests as a 32-bit binary, since vet wouldn't have caught the parseRetentionDays wrap. The test step only runs on X64 (arm64 runners can't run 386 binaries). Also fixed a couple more things while I was at it: * I left MaxFrameSize untyped since it's public API and typing it would break callers, so its use sites just compare in uint64 instead. * MaxRegionSize is internal, so I typed it as int64 at the definition and dropped the casts. * ReadFrame also panicked on 32-bit when a frame length was past MaxInt, so it returns an error now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
