amoghrajesh commented on code in PR #75643:
URL: https://github.com/apache/airflow/pull/75643#discussion_r4375922875
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLResponseForm.tsx:
##########
@@ -79,6 +79,13 @@ export const HITLResponseForm = ({ hitlDetail, namespace =
"hitl", onResponded }
const isPending = isHITLPending(hitlDetail.task_instance.state);
+ const chosenOptionsValue = paramsDict.chosen_options?.value;
+ const isSelectionMissing =
+ hitlDetail.multiple &&
Review Comment:
starts with `hitlDetail.multiple`, but the Respond button also renders when
multiple is false and `options.length > 4`, per `shouldRenderOptionButton` at
`:77`. A single choice request with 5 options still sends an empty
`chosen_options` and still shows the generic "Validation Error" this PR set out
to solve. Drop the multiple clause, and add a
`renderForm(["A","B","C","D","E"])` test with multiple set to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
