kacpermuda commented on code in PR #74805:
URL: https://github.com/apache/airflow/pull/74805#discussion_r4379805326
##########
providers/openlineage/src/airflow/providers/openlineage/utils/sql_hook_lineage.py:
##########
@@ -133,7 +133,8 @@ def _get_database_info(hook_id: int):
try:
return hook.get_openlineage_database_info(_get_connection(hook_id))
Review Comment:
Good catch. _get_database_info now looks the method up with getattr and
returns None when it’s missing, so AthenaHook, RedshiftDataHook and HiveCliHook
no longer log a warning. Only an exception raised from inside the method is
logged at WARNING. Added a test for a hook without the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
