youngduck98 commented on code in PR #75608:
URL: https://github.com/apache/airflow/pull/75608#discussion_r4380695721
##########
airflow-core/src/airflow/ui/src/pages/Run/Header.tsx:
##########
@@ -60,8 +61,10 @@ export const Header = ({ dagRun }: { readonly dagRun:
DAGRunResponse }) => {
const dagId = dagRun.dag_id;
const dagRunId = dagRun.dag_run_id;
- const { data: alertData } = useDeadlinesServiceGetDagDeadlineAlerts({ dagId
});
- const hasDeadlineAlerts = (alertData?.total_entries ?? 0) > 0;
+ const { data: alertData } = useDeadlinesServiceGetDagDeadlineAlerts({ dagId,
dagRunId, limit: 100 });
+ const hasDeadlineAlerts = (alertData?.deadline_alerts ?? []).some((alert) =>
+ isDeadlineAlertApplicable(alert, dagRun.run_type),
+ );
Review Comment:
Showing historical deadline results for a Dag run can be useful, but those
results can be misleading when an existing run is reprocessed as backfill and
its alert's run_type_filter excludes backfill. For this reason, the run header
shows the Deadline field only when an alert from the run's creation version
applies to its current run type. Historical records remain available in the
Deadlines list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
