Abdel39 opened a new pull request, #75679:
URL: https://github.com/apache/airflow/pull/75679

   With `[core] default_task_retries` set to a non-zero value, an explicit 
`retries=0` on a mapped task is dropped during serialization, and the scheduler 
fills it back from `client_defaults`:
   
   ```python
   # default_task_retries = 3
   BashOperator.partial(task_id="t", retries=0).expand(bash_command=["echo 1", 
"echo 2"])
   # -> max_tries == 3 for every mapped TI
   ```
   
   #57853 fixed this for DAG `default_args` and constructor kwargs by keeping a 
value that equals the schema default when it was set explicitly. Mapped 
operators keep explicit values in `partial_kwargs`, which that check never 
looked at. This adds the same check for `partial_kwargs`.
   
   `partial()` fills unset fields from `OPERATOR_DEFAULTS` (which already 
reflect `default_task_retries`), so a mapped task that does not set `retries` 
still gets the client default.
   
   One side effect: an operator subclass whose `__init__` declares `retries=0` 
as its default now keeps 0 when mapped, same as when it is not mapped.
   
   related: #57792, #58693
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to