vatsrahul1001 commented on PR #75414: URL: https://github.com/apache/airflow/pull/75414#issuecomment-6433151445
Reviewed as part of 3.4.0 RC1 triage. The deprecation itself is clean and I'm +1 on the approach — `__all__` is preserved, `from airflow.utils.email import *` keeps working, the shim is lazy (importing `airflow.utils.email` doesn't import the provider), and the three real behavior changes are well documented in the warning, the significant newsfragment, and the howto. Test coverage is good, including the server-process DB-connection path. One thing to flag for the **`v3-4-test` backport**, since it affects the 3.4.0 release: The emailer lives in `airflow.providers.smtp.utils.emailer`, added by #74623. That module is on `main` (smtp provider 3.2.0), but it is **not on `v3-4-test`** — that branch still carries the smtp provider at 3.1.1 with no `utils/emailer.py`, and #74623 has no milestone or `backport-to-v3-4-test` label. So when this PR backports to `v3-4-test`: - `tests/unit/utils/test_email.py` does `from airflow.providers.smtp.utils import emailer` → ImportError at collection → Core test lane red. - Any in-repo test exercising the email-alert path resolves the shim target, which isn't present in the branch's provider source. The shipped artifact is fine — core now pins `apache-airflow-providers-smtp>=3.2.0` and 3.2.0 is on PyPI with the emailer, so a real install resolves correctly. This is purely branch-consistency/CI. The fix is to also backport #74623 (emailer) to `v3-4-test` before this one lands there. I'm kicking that off now. Note: the floor bump needs the `allow provider dependency bump` label here (adding it) and will need it again on the backport PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
