aaiss0927 opened a new pull request, #75740:
URL: https://github.com/apache/airflow/pull/75740
Add the five missing Korean (ko) translations that restore key parity with
the English locale:
| File | Key | English | Korean |
|---|---|---|---|
| `dag.json` | `versions.pathOccurrences_one` | {{count, number}} change
shares this path | 변경 {{count, number}}개가 이 경로를 공유합니다 |
| `dag.json` | `versions.pathOccurrences_other` | {{count, number}} changes
share this path | 변경 {{count, number}}개가 이 경로를 공유합니다 |
| `dag.json` | `versions.pathOccurrencesAtLeast_one` | At least {{count,
number}} change shares this path | 변경 {{count, number}}개 이상이 이 경로를 공유합니다 |
| `dag.json` | `versions.pathOccurrencesAtLeast_other` | At least {{count,
number}} changes share this path | 변경 {{count, number}}개 이상이 이 경로를 공유합니다 |
| `hitl.json` | `response.selectAtLeastOne` | Select at least one option |
옵션을 하나 이상 선택하세요 |
Notes:
- These five keys were added to the English locale **after** the currently
open Korean batch PR #75415 branched: `versions.pathOccurrences*` by #75433 and
`response.selectAtLeastOne` by #75643 — so they are not covered by that PR.
This PR intentionally contains **only** these five keys and does not overlap
#75415 (same de-duplication approach as #70005). related: #75415
- `_one`/`_other` share the same Korean string, following the existing ko
locale convention (e.g. `versions.summary_one/_other`).
- The `pathOccurrences*` strings are the tooltip on the `×N` badge in the
Dag **Versions** diff, shown when several changes are merged into one row
because they share a path. The badge appears only for users **without Dag code
read access** (values-redacted mode); the `AtLeast` variant is used when the
diff was truncated by the max-changes limit (`×N+`).
- `selectAtLeastOne` is the validation message in the Human-in-the-loop
response form when no option of a multiple-choice request is selected.
---
### Screenshots
Validation message when no option of a multiple-choice HITL request is
selected (`response.selectAtLeastOne`):
<!-- screenshot-hitl -->
Tooltip on the `×3` badge in the Dag Versions diff, viewed without Dag code
read access (`versions.pathOccurrences_other`):
<!-- screenshot-occurrences -->
Truncated diff (Max changes = 1): the `×3+` badge with the lower-bound
tooltip (`versions.pathOccurrencesAtLeast_other`). The English "At least 3
changes" summary line is `summaryAtLeast`, which is covered by #75415:
<!-- screenshot-atleast -->
---
### Test
`breeze ui check-translation-completeness --language ko`
<!-- screenshot-test -->
On this branch the five keys are no longer reported (`hitl.json` **100%**,
`dag.json` missing 22 → 18). The remaining 38 missing / 13 unused keys are
exactly the set being handled by #75415, so ko coverage reaches 100% once both
PRs land.
cc @onestn @noeunkim
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Claude Fable5
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
