kaxil commented on code in PR #74519:
URL: https://github.com/apache/airflow/pull/74519#discussion_r4393905663
##########
providers/openai/tests/unit/openai/operators/test_openai.py:
##########
@@ -918,20 +918,39 @@ def test_pushes_response_id_and_usage(self, do_xcom_push,
expected_push_count):
key="usage", value={**usage.model_dump(mode="json"),
"try_number": 2}
)
- def test_rejected_response_still_records_id_and_usage(self):
+ @pytest.mark.parametrize(
+ ("response_kwargs", "expected_error"),
Review Comment:
Small one: `response_kwargs` already means the operator argument in this
class (`self._operator(response_kwargs={"instructions": ...})` a few tests up),
but here it holds fields of the fake `ParsedResponse` coming back. Could we
call it `response_fields` so it doesn't read like the request is what varies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
