potiuk opened a new pull request, #75827: URL: https://github.com/apache/airflow/pull/75827
Follow-up to #74909, which closes a gated pull request that changes the fork CI gate. Two gaps let such a pull request still get `CI passed` without CI, and one could close a pull request by mistake. - **Jobs that run in a gated run.** In a run the gate leaves to fork CI, the gate succeeds and only `build-info` is skipped. A job still runs when its `if` calls `always()`, `success()`, `failure()` or `cancelled()` (in any case), or when all the jobs it needs run. On `main` these are `check-run-needed`, `check-timed-out-jobs`, `ci-passed`, `finalize-tests` and `notify-slack`. Only which jobs do not depend on the gate was compared, so a pull request could rename `ci-passed`, or add a job needing only the gate, and report `CI passed`. Their whole definitions are now part of the gate. - **Job names.** GitHub treats a skipped required check as passed, so a job that is skipped in a gated run and renamed to `CI passed` satisfies the merge ruleset as well. The `name` of every job is now part of the gate, with its `strategy` when the name is an expression. A gated pull request that renames any job is closed; a maintainer can release it with `use project ci`. - **Fail closed.** A head `ci-amd.yml` with YAML aliases (which `ci-amd.yml` does not use, and which can expand exponentially when compared), or one the comparison fails on, counts as a gate change. - **Retargets during the check.** The changed files are listed as the pull request is when listed, so the base branch is now read again with the head commit. A retarget to a base without the gate in between no longer closes a pull request that should be released to project CI. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Claude Opus 5) Generated-by: Claude Code (Claude Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
