uranusjr commented on code in PR #70671:
URL: https://github.com/apache/airflow/pull/70671#discussion_r4397670843
##########
providers/amazon/tests/unit/amazon/aws/log/test_s3_task_handler.py:
##########
@@ -492,7 +499,10 @@ def test_read_when_s3_log_missing(self):
if AIRFLOW_V_3_0_PLUS:
log = list(log)
assert len(log) == 2
- assert metadata == {"end_of_log": True, "log_pos": 0}
+ if AIRFLOW_V_3_4_PLUS:
+ assert metadata == {"end_of_log": True}
+ else:
+ assert metadata == {"end_of_log": True, "log_pos": 0}
Review Comment:
Instead of if-else blocks in a bunch of provider tests, let’s assert only
what these provider tests care about i.e. `assert metadata["end_of_log"] is
True`. `log_pos` is a core detail that core tests already cover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
