Alwaysgaurav1 commented on PR #75809: URL: https://github.com/apache/airflow/pull/75809#issuecomment-6464313773
Hi @aaiss0927, Thank you for the thorough review and for providing the reproducible test probes! I have pushed an update addressing all three points: 1. **Stdout redirection & fatal error replay:** Adopted the `breeze ci verify --json` pattern using `contextlib.redirect_stdout(...)`. Console narration is suppressed to an in-memory buffer (or streamed to `stderr` with `--verbose`). If the computation aborts (e.g. unsupported plural suffixes or malformed JSON), the captured narration is replayed to `stderr` in the `finally` block, keeping `stdout` completely pure for `jq`. 2. **Clean error handling for malformed locale files:** Unreadable file narration is now captured by the stdout redirection rather than leaking to `stdout`. 3. **Preserved table mode behavior:** Restored table mode's execution order so that `--language` validation occurs at the exact same step as upstream, ensuring byte-identical table output before exiting with status `2`. 4. **Regression tests:** Adopted your 3 test probes into `dev/breeze/tests/test_ui_commands.py` (all 48 tests passing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
