Lee-W commented on code in PR #72940:
URL: https://github.com/apache/airflow/pull/72940#discussion_r4398490238
##########
registry/src/provider-version.njk:
##########
@@ -334,6 +317,33 @@ eleventyComputed:
</section>
{% endif %}
+ {% if externalServiceRows.length > 0 %}
+ <section class="external-services-card card">
+ <h3>
+ <svg fill="none" stroke="currentColor" viewBox="0 0 24 24"
aria-hidden="true">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2"
d="M11 5.882V19.24a1.76 1.76 0 01-3.417.592l-2.147-6.15M18 13a3 3 0 100-6M5.436
13.683A4.001 4.001 0 017 6h1.832c4.1 0 7.625-1.234
9.168-3v14c-1.543-1.766-5.067-3-9.168-3H7a3.988 3.988 0 01-1.564-.317z" />
+ </svg>
+ External Services ({{ externalServiceRows.length }})
Review Comment:
Dropped the count from the External Services heading.
##########
registry/src/provider-version.njk:
##########
@@ -334,6 +317,33 @@ eleventyComputed:
</section>
{% endif %}
+ {% if externalServiceRows.length > 0 %}
+ <section class="external-services-card card">
+ <h3>
+ <svg fill="none" stroke="currentColor" viewBox="0 0 24 24"
aria-hidden="true">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2"
d="M11 5.882V19.24a1.76 1.76 0 01-3.417.592l-2.147-6.15M18 13a3 3 0 100-6M5.436
13.683A4.001 4.001 0 017 6h1.832c4.1 0 7.625-1.234
9.168-3v14c-1.543-1.766-5.067-3-9.168-3H7a3.988 3.988 0 01-1.564-.317z" />
+ </svg>
+ External Services ({{ externalServiceRows.length }})
+ </h3>
+ <table class="external-services-table">
+ <thead>
+ <tr class="external-services-header">
+ <th>Name</th>
Review Comment:
The column header is back to "Connection type", and the card has a one-line
intro saying the list is examples taken from the external-services each
connection type declares in provider.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
