yuseok89 commented on code in PR #75818:
URL: https://github.com/apache/airflow/pull/75818#discussion_r4402870841
##########
airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldNumber.tsx:
##########
@@ -32,20 +36,44 @@ export const FieldNumber = ({ name, namespace = "default",
onUpdate }: FlexibleF
// "undefined" values are removed from params, so we set it to null to
avoid falling back to DAG defaults.
paramsDict[name].value = null;
}
- } else {
- // Convert the string to a number if a valid value is entered
- if (paramsDict[name]) {
- paramsDict[name].value = Number(value);
- }
+
+ setParamsDict(paramsDict);
+ onUpdate(value);
+
+ return;
+ }
+
+ // Convert the string to a number if a valid value is entered
+ const numericValue = Number(value);
+
+ if (paramsDict[name]) {
+ paramsDict[name].value = numericValue;
}
setParamsDict(paramsDict);
+
+ const violation = getParamRangeViolation(numericValue, param.schema);
Review Comment:
I tried a form with this param and a second string param. After typing 6666
here and then editing the other field, the inline error stays but Trigger seems
to be enabled again.
Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
