kaxil commented on code in PR #75909:
URL: https://github.com/apache/airflow/pull/75909#discussion_r4406060687
##########
providers/common/ai/src/airflow/providers/common/ai/hooks/pydantic_ai.py:
##########
@@ -404,7 +435,8 @@ def _qualify_model_name(self, model_name: str, *,
forwarded_from_conn_id: str |
return model_name
if _has_recognized_provider_prefix(model_name):
return model_name
- if self.model_provider is not None:
+ model_provider = self._get_model_provider()
Review Comment:
Fixed in a23004a: the warning now only fires on the vendor types, and the
gateway section shows `openai-chat:mistral:7b` for a tag whose name is also a
provider.
##########
providers/common/ai/docs/connections/pydantic_ai.rst:
##########
@@ -193,5 +229,6 @@ The hook reads the model from these sources in priority
order:
Whichever name is chosen, a name that already pins a recognized platform (its
segment
before the first ``:`` is itself a pydantic-ai provider) is used verbatim; a
bare name is
-qualified with this connection's platform, and this generic connection type
has none,
-so a bare name reaching this step always raises.
+qualified with this connection's platform. This generic connection type takes
its platform
+from Default Provider (``extra["provider"]``); without one, a bare name
reaching this step
Review Comment:
Fixed in a23004a: the sentence now covers sources 1-3 and says the spec-file
model goes to pydantic-ai as written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
