kaxil commented on PR #74279: URL: https://github.com/apache/airflow/pull/74279#issuecomment-6481017145
Nice, the demo makes it clear: psycopg 3 cancels, the blocking C drivers don't. Still worth having since psycopg 3 is the default on 3.3. 1. The `cancel_query` docstring says `oracledb` and `trino` work, but only psycopg 3 has been tested. Can you run the same check on Trino, or drop those two from the docstring? 2. `execute()` sets `hook._cancel_on_interrupt`, a private attribute, from the operator. Please make it public on `DbApiHook` so custom hooks and subclasses can use it. +1 on psycopg2 and SQLite as follow-up PRs in their providers. Snowflake can get the same by using `_track_running_cursor` in its `_run_command`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
