ephraimbuddy commented on code in PR #75670:
URL: https://github.com/apache/airflow/pull/75670#discussion_r4399592848
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -1609,6 +1604,17 @@ def _sort_by_mtime(self, files: Iterable[DagFileInfo]):
return file_infos, changed_recently
def processed_recently(self, now, file):
+ """
+ Return whether ``file`` finished parsing within
``min_file_process_interval``.
+
+ .. deprecated:: 3.5.0
+ The Dag processor no longer uses this method. It will be removed
in Airflow 4.
+ """
+ warnings.warn(
+ "DagFileProcessorManager.processed_recently is deprecated and will
be removed in Airflow 4.",
+ RemovedInAirflow4Warning,
Review Comment:
I rereviewed this and I think we should follow the pattern in BaseExecutor
so we can reach outside callers.
Can we follow `_warn_deprecated_executor_usage` and also log.warning it,
once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
