Lee-W commented on code in PR #75943:
URL: https://github.com/apache/airflow/pull/75943#discussion_r4409992782
##########
airflow-core/tests/unit/jobs/test_scheduler_job.py:
##########
@@ -13034,6 +13034,164 @@ def
test_create_dagruns_asset_and_time_late_arrival_uses_oldest_pending_logical_
)
[email protected]
+def _capture_max_bind_params(session: Session):
+ """Track the largest number of bind parameters sent in a single SQL
statement."""
+ from sqlalchemy import event as sa_event
Review Comment:
do we need do local import here? even if so, `from sqlalchemy import event`
is probalby better
##########
airflow-core/tests/unit/jobs/test_scheduler_job.py:
##########
@@ -13034,6 +13034,164 @@ def
test_create_dagruns_asset_and_time_late_arrival_uses_oldest_pending_logical_
)
[email protected]
+def _capture_max_bind_params(session: Session):
+ """Track the largest number of bind parameters sent in a single SQL
statement."""
+ from sqlalchemy import event as sa_event
Review Comment:
do we need do local import here? even if so, `from sqlalchemy import event`
is probalby better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
