shahar1 commented on code in PR #74127:
URL: https://github.com/apache/airflow/pull/74127#discussion_r4417572052
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/deadlines.py:
##########
@@ -182,6 +184,10 @@ def get_dag_deadline_alerts(
dag_id: str,
session: SessionDep,
limit: QueryLimit,
+ name_pattern: Annotated[
+ _SearchParam,
+ Depends(search_param_factory(DeadlineAlert.name, "name_pattern")),
Review Comment:
**nit** — `search_param_factory` generates the description *"Slower than
`name_prefix_pattern` on large tables"* (see `_private_ui.yaml` and the
generated TS docs in this PR), but this endpoint has no `name_prefix_pattern`
parameter. Every other `*_pattern` route in `core_api/routes` pairs it with a
`prefix_search_param_factory` twin (`dag_run.py`, `task_instances.py`,
`event_logs.py`, `ui/grid.py`). Either add `name_prefix_pattern` for
consistency, or leave it — alerts per Dag are few, so the speed hint does not
matter here. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
