o-nikolas commented on code in PR #75997:
URL: https://github.com/apache/airflow/pull/75997#discussion_r4425717752
##########
providers/amazon/tests/unit/amazon/aws/hooks/test_duckdb.py:
##########
@@ -305,3 +307,20 @@ def
test_explicit_argument_wins_over_the_connection_extra(self, aws_base_hook):
with mock.patch(GET_CONNECTION,
return_value=self.duckdb_connection(secret_name="from_extra")):
statement = secret_statement(AwsDuckDBHook(secret_name="explicit"))
assert statement.startswith("CREATE OR REPLACE SECRET explicit (")
+
+
+class TestAwsDuckDBHookIdentityLookup:
Review Comment:
I actually intentionally kept it to just one test, the code is so simple
that it will log, I mostly just wanted to test the two most important things 1)
the failures don't disrupt anything and 2) is the code still there and present
(which this test also does). The happy path mostly just test STS, and the
logging system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
